Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant prerequisite steps from the default optimizer sequence #15092

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Remove redundant prerequisite steps from the default optimizer sequence #15092

wants to merge 1 commit into from

Conversation

cameel
Copy link
Member

@cameel cameel commented May 11, 2024

Since gho steps are hard-coded as prerequisites, there's not much point in having them in the default sequence. All other steps are supposed to preserve these properties.

For now this is just to verify that removing them does not really change generated bytecode in a meaningful way.

If this is true, we might consider merging it, though that would probably be better done only after rebasing it on the new sequence (#15030). Otherwise merging it would just revert it.

@cameel cameel self-assigned this May 11, 2024
@cameel cameel force-pushed the remove-redundant-prerequisites-from-default-sequence branch from 80c293d to 1462e34 Compare May 13, 2024 17:14
@cameel
Copy link
Member Author

cameel commented May 13, 2024

Rebased on top of the new sequence.

r0qs
r0qs reviewed May 15, 2024
View reviewed changes
Copy link
Member

@r0qs r0qs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to update the docs with this new default sequence, right? I guess we mention it there.

@cameel
Copy link
Member Author

cameel commented May 15, 2024

No, we don't really document the default sequence.

We need a changelog entry though.

@github-actions GitHub Actions
Copy link

This pull request is stale because it has been open for 14 days with no activity.
It will be closed in 7 days unless the stale label is removed.

@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label May 30, 2024
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label May 30, 2024
@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Jun 14, 2024
@ethereum ethereum deleted a comment from github-actions bot Jun 14, 2024
@r0qs r0qs removed the stale The issue/PR was marked as stale because it has been open for too long. label Jun 14, 2024
@github-actions GitHub Actions
Copy link

This pull request is stale because it has been open for 14 days with no activity.
It will be closed in 7 days unless the stale label is removed.

@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Jun 29, 2024
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label Jun 30, 2024
@github-actions GitHub Actions
Copy link

This pull request is stale because it has been open for 14 days with no activity.
It will be closed in 7 days unless the stale label is removed.

@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Jul 14, 2024
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label Jul 15, 2024
@github-actions GitHub Actions
Copy link

This pull request is stale because it has been open for 14 days with no activity.
It will be closed in 7 days unless the stale label is removed.

@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Jul 29, 2024
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label Jul 30, 2024
@github-actions GitHub Actions
Copy link

This pull request is stale because it has been open for 14 days with no activity.
It will be closed in 7 days unless the stale label is removed.

@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Aug 13, 2024
@ekpyron ekpyron removed the stale The issue/PR was marked as stale because it has been open for too long. label Aug 15, 2024
@github-actions GitHub Actions
Copy link

This pull request is stale because it has been open for 14 days with no activity.
It will be closed in 7 days unless the stale label is removed.

@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Aug 30, 2024
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label Aug 31, 2024
@github-actions GitHub Actions
Copy link

This pull request is stale because it has been open for 14 days with no activity.
It will be closed in 7 days unless the stale label is removed.

@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Sep 15, 2024
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label Sep 16, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

This pull request is stale because it has been open for 14 days with no activity.
It will be closed in 7 days unless the stale label is removed.

@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Oct 1, 2024
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label Oct 1, 2024
@github-actions GitHub Actions
Copy link

This pull request is stale because it has been open for 14 days with no activity.
It will be closed in 7 days unless the stale label is removed.

@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Oct 16, 2024
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label Oct 17, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024

This pull request is stale because it has been open for 14 days with no activity.
It will be closed in 7 days unless the stale label is removed.

@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Nov 1, 2024
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r0qs r0qs r0qs left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@cameel cameel

Labels
optimizer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cameel @r0qs @ekpyron